STM32: Refactor us_ticker files #7290

bcostm · 2018-06-21T11:17:06Z

Description

This PR re-arrange the files used to manage the us_ticker. Previously the code was mixed in different files (us_ticker.c, hal_tick_16b.c, hal_tick_32b.c, hal_tick_common.c, hal_tick.h).

Now:

All the code to manage the us_ticker is in us_ticker.c and us_ticker_data.h files
The hal_tick_overrides.c file contains only the ST HAL Tick functions redefinitions (weak)

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr

Lot's of cloned file changes. Hoping this was done by script, and not by hand!

Was much easier to tell what happened via each commit instead of the overall diff.

cmonr · 2018-06-21T16:49:13Z

/morph build

mbed-ci · 2018-06-21T19:13:09Z

Build : SUCCESS

Build number : 2425
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7290/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-21T20:29:59Z

Exporter Build : SUCCESS

Build number : 2054
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7290/

mbed-ci · 2018-06-22T02:58:42Z

Test : FAILURE

Build number : 2205
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7290/2205

cmonr · 2018-06-22T04:39:05Z

@bcostm Please take a look at the test failures. On quick glance, they all appear to be related to ST boards and tickers.

bcostm · 2018-06-22T05:35:03Z

Lot's of cloned file changes. Hoping this was done by script, and not by hand!

Yes I used sed/find commands to do it (too lazy to do it manually on 55 files :))

I will check the errors

0xc0170 · 2018-06-27T08:28:43Z

@bcostm Any update for the failures above?

bcostm · 2018-06-27T08:35:33Z

I've managed to make one test pass but it causes other tests to be fail... I put this PR on hold for now until Issue #7316 is fixed because same files/functions are used.

cmonr · 2018-07-03T12:49:57Z

For tracking, looks like the PR that will fix #7316 is #7352

cmonr · 2018-07-09T15:29:35Z

@bcostm #7352 just came in, so weel free to continue when possible!

bcostm · 2018-07-10T12:13:55Z

I have rebased and added what has been done in PR #7352. Tests on several boards on-going. I'll give the status when they'll be terminated.

jeromecoutant · 2018-07-11T12:11:06Z

Hi
Results from ST CI bench are all good
Thx

0xc0170 · 2018-07-11T12:27:50Z

Can be the commit messages improved? typo, additional changes, other fixes could be: stm32 ticker: fix macro name , stm32 ticker: changing something , stm32 ticker: fixing what and why

- rename hal_tick_common.c in hal_tick_overrides.c - move 16 and 32bits timer functions in us_ticker.c

- rename TIM_MST_16BIT in TIM_MST_BIT_WIDTH in order to use it directly in ticker info structure - change HAL_InitTick() and HAL_GetTick()

… issue with 16-bit timer - Move back the 16/32bit timer initialization in HAL_InitTick() and not in us_ticker_init() - Use ticker_read_us() and us_ticker_read() in HAL_GetTick() to fix potential overflow issue with the 16bit timer ==> These corrections allow timer, rtc, sleep, tick tests to PASS

bcostm · 2018-07-11T12:54:04Z

OK. Commit messages updated.

0xc0170 · 2018-07-11T13:41:44Z

/morph build

mbed-ci · 2018-07-11T15:06:51Z

Build : SUCCESS

Build number : 2569
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7290/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-07-11T16:36:38Z

Exporter Build : SUCCESS

Build number : 2213
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7290/

mbed-ci · 2018-07-11T18:35:03Z

Test : SUCCESS

Build number : 2323
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7290/2323

bcostm · 2018-07-12T13:19:29Z

I don't see the release-version:5.9.3 tag ?

STM32: Refactor us_ticker files

0xc0170 added the needs: review label Jun 21, 2018

0xc0170 requested a review from a team June 21, 2018 11:25

jeromecoutant approved these changes Jun 21, 2018

View reviewed changes

bcostm changed the title ~~STM32: Refactor file to manage us_ticker~~ STM32: Refactor us_ticker files Jun 21, 2018

cmonr approved these changes Jun 21, 2018

View reviewed changes

cmonr added needs: CI release-version: 5.9.2 and removed needs: review labels Jun 21, 2018

cmonr added needs: work and removed needs: CI labels Jun 22, 2018

cmonr removed the release-version: 5.9.2 label Jun 28, 2018

cmonr added needs: preceding PR and removed needs: preceding PR labels Jul 3, 2018

bcostm force-pushed the refactor_us_ticker branch from 61c52f6 to 1bf4bca Compare July 10, 2018 11:55

bcostm added 3 commits July 11, 2018 14:36

stm32 ticker: rename files and move functions

b1bbd76

- rename hal_tick_common.c in hal_tick_overrides.c - move 16 and 32bits timer functions in us_ticker.c

stm32 ticker: rename macro and update ST HAL Tick functions

fbd7a97

- rename TIM_MST_16BIT in TIM_MST_BIT_WIDTH in order to use it directly in ticker info structure - change HAL_InitTick() and HAL_GetTick()

stm32 ticker: rename hal_tick.h in us_ticker_data.h

32031cb

bcostm added 4 commits July 11, 2018 14:43

stm32 ticker: change license

d8e839a

stm32 ticker: typo corrections

7097e07

stm32 ticker: corrections in order to pass tests

fc50e28

bcostm force-pushed the refactor_us_ticker branch from 1bf4bca to 0b133be Compare July 11, 2018 12:52

0xc0170 approved these changes Jul 11, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jul 11, 2018

cmonr added ready for merge and removed needs: CI labels Jul 11, 2018

cmonr merged commit 19c6f3b into ARMmbed:master Jul 12, 2018

0xc0170 removed the ready for merge label Jul 12, 2018

0xc0170 added the release-version: 5.9.3 label Jul 12, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7290 from bcostm/refactor_us_ticker

222b7ee

STM32: Refactor us_ticker files

bcostm deleted the refactor_us_ticker branch October 29, 2018 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32: Refactor us_ticker files #7290

STM32: Refactor us_ticker files #7290

bcostm commented Jun 21, 2018 •

edited

Loading

cmonr left a comment

cmonr commented Jun 21, 2018

mbed-ci commented Jun 21, 2018

mbed-ci commented Jun 21, 2018

mbed-ci commented Jun 22, 2018

cmonr commented Jun 22, 2018

bcostm commented Jun 22, 2018

0xc0170 commented Jun 27, 2018

bcostm commented Jun 27, 2018

cmonr commented Jul 3, 2018

cmonr commented Jul 9, 2018

bcostm commented Jul 10, 2018

jeromecoutant commented Jul 11, 2018

0xc0170 commented Jul 11, 2018 •

edited

Loading

bcostm commented Jul 11, 2018

0xc0170 commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

bcostm commented Jul 12, 2018

STM32: Refactor us_ticker files #7290

STM32: Refactor us_ticker files #7290

Conversation

bcostm commented Jun 21, 2018 • edited Loading

Description

Pull request type

cmonr left a comment

Choose a reason for hiding this comment

cmonr commented Jun 21, 2018

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented Jun 21, 2018

Exporter Build : SUCCESS

mbed-ci commented Jun 22, 2018

Test : FAILURE

cmonr commented Jun 22, 2018

bcostm commented Jun 22, 2018

0xc0170 commented Jun 27, 2018

bcostm commented Jun 27, 2018

cmonr commented Jul 3, 2018

cmonr commented Jul 9, 2018

bcostm commented Jul 10, 2018

jeromecoutant commented Jul 11, 2018

0xc0170 commented Jul 11, 2018 • edited Loading

bcostm commented Jul 11, 2018

0xc0170 commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented Jul 11, 2018

Exporter Build : SUCCESS

mbed-ci commented Jul 11, 2018

Test : SUCCESS

bcostm commented Jul 12, 2018

bcostm commented Jun 21, 2018 •

edited

Loading

0xc0170 commented Jul 11, 2018 •

edited

Loading