-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MBEDTLS_HAVE_DATE_TIME as ARMCC does not support gmtime #7868
Disable MBEDTLS_HAVE_DATE_TIME as ARMCC does not support gmtime #7868
Conversation
cc @sbutcher-arm |
Maintainers - can you please add @k-stachowiak and @AndrzejKurek as reviewers? @k-stachowiak - Can you please test this PR on a board and append to this PR what test you did when you have? |
I built (with ARM and GCC_ARM compilers) and ran (on a K64F board) all the mbed-os-example-tls examples (master branch) updated with mbed-os.lib pointing to: "[email protected]:andresag01/mbed/#d7519565d22249fa2c0f2ec4c60a2c0e3981b916", which is the last commit in this PR.
|
/morph build |
Build : SUCCESSBuild number : 2938 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2557 |
Test : SUCCESSBuild number : 2688 |
I would have prefered this somehow be an ARM-only change, but this is fine as well since it simplifies maintenance overhead. |
Description
This PR reverts the change #4846 which enabled the feature MBEDTLS_HAVE_DATE_TIME in Mbed TLS as the libc used by the ARM toolchain does not fully implement the gmtime() function that this feature relies on.
Pull request type