Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mbed TLS to version 2.13.0 #7974

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

simonbutcher
Copy link
Contributor

@simonbutcher simonbutcher commented Sep 3, 2018

Description

This PR updates Mbed TLS to the latest release, 2.13.0.

This PR supersedes PR #7940 which unfortunately I can't update, so have had to provide a new PR. #7940 can now be closed.

Note, this PR is title/tagged 'DO NOT MERGE' whilst formal release approval is pending.

PR should be reviewed by @RonEld and/or @Patater where available.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Breaking change

Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've verified the mbedtls code is identical to that in #7940, except that the version information has been updated.

@adbridge
Copy link
Contributor

adbridge commented Sep 3, 2018

/morph build

@adbridge
Copy link
Contributor

adbridge commented Sep 3, 2018

Not to be merged until release approval has been obtained by the TLS team and communicated to us

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2018

Build : FAILURE

Build number : 2999
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7974/

@simonbutcher
Copy link
Contributor Author

I'm pleased to say this version has been approved for release, so the 'DO NOT MERGE' label can be removed.

@cmonr
Copy link
Contributor

cmonr commented Sep 3, 2018

/morph build

Yay, a new CI issue. The node failued to report the build success...

@cmonr cmonr removed the do not merge label Sep 3, 2018
@mbed-ci
Copy link

mbed-ci commented Sep 3, 2018

Build : SUCCESS

Build number : 3000
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7974/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

@0xc0170 0xc0170 merged commit dd91b90 into ARMmbed:master Sep 4, 2018
@juhoeskeli
Copy link
Contributor

Does not link succesfully with ARMCC & IAR: x509.c@907,0: #223-D: function "gmtime_r" declared implicitly

@juhoeskeli
Copy link
Contributor

Tested with armcc 5.06

@RonEld
Copy link
Contributor

RonEld commented Sep 4, 2018

@juhoeskeli This issue is opened in Mbed-TLS/mbedtls#1907
I believe a workaropund should be to disable MBEDTLS_HAVE_TIME_DATE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants