Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add salt #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add salt #5

wants to merge 1 commit into from

Conversation

neurabenn
Copy link

Add salt to reduce hash clashing

jakobj
jakobj reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this! 🚀

i'm wondering, are the hashes for different salts with the same password actually different?

@Debilski
Copy link
Member

Debilski commented Sep 5, 2022

I think you also need to check the actual validation function if I’m not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj jakobj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neurabenn @Debilski @jakobj