Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip specialization if no used types in dependency #14

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

Deee92
Copy link
Contributor

@Deee92 Deee92 commented Nov 1, 2022

Deptrim was generating specialized jars and corresponding poms for dependencies with no used types. We only specialize and produce poms for dependencies where number of used types is non-zero. This addresses #13.

@cesarsotovalero
Copy link
Contributor

cesarsotovalero commented Nov 1, 2022

@Deee92 I tried the change for the target project, but now only one pom is produced and no jar is copied to libs-trimmed. Do you have a different output on your side?

@Deee92
Copy link
Contributor Author

Deee92 commented Nov 1, 2022

Yes, I have 2 dependencies in both libs-deptrim/ and dependency-debloated/. I also get 4 pom-debloated-spl-* files (+1 pom-debloated from depclean). Classic works on my machine.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cesarsotovalero
Copy link
Contributor

@Deee92 It worked on my side now. I guess is was something with the Maven configs in my IDE. So, this fix #13.

@cesarsotovalero cesarsotovalero merged commit eba1642 into main Nov 1, 2022
@cesarsotovalero cesarsotovalero deleted the issue13_extra_poms branch November 1, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants