Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for stats-output-file in maven-plugin #907

Closed
wants to merge 47 commits into from

Conversation

algomaster99
Copy link
Member

The feature introduced works as it would work in CLI when --stats-output-file is passed to mine subcommand. However, the originalArgs calculation is a bit broken. It does not correctly output the source and the ruleKey passed.

Current output

"executionInfo": {
       ...
      "originalArgs": [
          "repair",
          "-Drules",
           null,
          "-Dsource",
          null,
          "-DstatsOutputFile",
          "stats.json"
      ]
  },

Expected output

"executionInfo": {
       ...
      "originalArgs": [
          "repair",
          "-DruleKey",
           "S2111",
          "-Dsource",
          "/path/to/project",
          "-DstatsOutputFile",
          "stats.json"
      ]
  },

* It is just a prototype right now.
* Only `ruleKey` parameter has been extended.
* Turns out maven plugin does not suppress output to SDTOUT
This reverts commit e3c8e11.
static class FileConverterForMojo extends AbstractBasicConverter {
@Override
protected Object fromString(String userInput) {
return new File(userInput);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PATH_TRAVERSAL_IN: This API (java/io/File.(Ljava/lang/String;)V) reads a file whose location might be specified by user input


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 17, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

* @return the list of arguments passed to the maven-plugin
*/
protected List<String> getMavenArgs() {
String[] rawCommand = System.getProperty("sun.java.command").split(" ");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NULL_DEREFERENCE: object returned by getProperty("sun.java.command") could be null and is dereferenced at line 64.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Base automatically changed from maven-plugin to master October 17, 2022 15:20
@algomaster99
Copy link
Member Author

Too lazy to rebase so closing it. I will open a separate PR by cherry-picking the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant