feat(app-rfi): only display plan if rfiDisplay true #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsamuelson
requested changes
Sep 25, 2024
There was a problem hiding this comment.
PR is missing handling for the following requirement:
Update top level component display logic so if the component is preconfigured to display a plan that has rfiDisplay set to false, we display nothing. This would guard against status changes, forms configured for display false plans, AND for cases where Degree Listing pages send people to degrees that are set to rfiDisplay false.
| @@ -106,6 +110,9 @@ export const normalizeDegreeData = data => { | |||
|
|
|||
| // Already formated title (BS) | |||
| title: curr.title, | |||
|
|
|||
| // Online Api does not have this field so we are going to always set it to true | |||
| rfiDisplay: true, | |||
| }; | |||
There was a problem hiding this comment.
Nice normalization pattern. Also appreciate the comment in this case. Thx!.
mlsamuelson
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links
FOR APPROVERS