chore(unity-react-core): control render framework per story #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am working on a few more changes to get the build. I will add comments as a code review |
Comment on lines
6
to
9
| addons: [ | ||
| "../../../.storybook-config", | ||
| "../../../.storybook-config/dataLayerListener", | ||
| "@whitespace/storybook-addon-html", | ||
| "@storybook/addon-links", | ||
| "@storybook/addon-essentials", | ||
| '@storybook/addon-a11y', | ||
| "storybook-css-modules-preset", | ||
| getAbsolutePath("@whitespace/storybook-addon-html"), | ||
| getAbsolutePath("@storybook/addon-links"), |
There was a problem hiding this comment.
do not remove
"../../../.storybook-config",
"../../../.storybook-config/dataLayerListener",
Comment on lines
14
to
15
| ], | ||
| core: { | ||
| builder: '@storybook/builder-vite' | ||
| }, |
There was a problem hiding this comment.
do not remove
Comment on lines
63
to
67
| "@storybook/react-vite": "^7.6.14", | ||
| "@storybook/addon-a11y": "^8.5.1", | ||
| "@storybook/addon-essentials": "^8.5.1", | ||
| "@storybook/addon-interactions": "^8.5.1", | ||
| "@storybook/addon-links": "^8.5.1", | ||
| "@storybook/builder-vite": "^8.5.1", | ||
| "@storybook/components": "^8.5.1", | ||
| "@storybook/jest": "^0.2.3", | ||
| "@storybook/manager-api": "^8.5.1", | ||
| "@storybook/react": "^8.5.1", | ||
| "@storybook/react-vite": "^8.5.1", | ||
| "@storybook/test": "^8.5.1", | ||
| "@storybook/test-runner": "^0.21.0", |
There was a problem hiding this comment.
remove dependencies that do not apply with this update (I added a few during discovery that we are not using... YET)
| coverage: { | ||
| // 👇 Add this | ||
| exclude: [ | ||
| ...coverageConfigDefaults.exclude, | ||
| '**/.storybook/**', | ||
| // 👇 This pattern must align with the `stories` property of your `.storybook/main.ts` config | ||
| '**/*.stories.*', | ||
| // 👇 This pattern must align with the output directory of `storybook build` | ||
| '**/storybook-static/**', | ||
| ], | ||
| }, | ||
| environment: "jsdom", | ||
| setupFiles: ["./vitest.setup.ts"], |
There was a problem hiding this comment.
Remove. This adds tests that can be run from storybook, which is super cool. but out of scope for this ticket
scott-williams-az
force-pushed
the
uds-1930-framework-control
branch
2 times, most recently
from
8e2fa5e to
3e09a2e
Compare
scott-williams-az
force-pushed
the
uds-1930-framework-control
branch
from
c80333f to
05c4182
Compare
mlsamuelson
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Component consolidation #1346 (review)
carousel based stories need to force React version. When Bootstrap version displays, they are not interactive.
Modal and Tabbed Panels stories throw error on Docs page.