Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add link to Foreman Resource Quota docs #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bastian-src
Copy link
Contributor

@bastian-src bastian-src commented Jan 22, 2025

The current welcome page looks like this:

image

This PR links from the Resource Quota welcome page to Foreman docs:

image

The documentation link re-directs users to the following page:

https://docs.theforeman.org/nightly/Administering_Project/index-katello.html#limiting-host-resources

Closes #92.

@bastian-src
Copy link
Contributor Author

I'm also about to add tests together with @Thorben-D.

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to documentation works; made some minor suggestions.

webpack/components/ResourceQuotaEmptyState/index.js Outdated Show resolved Hide resolved
webpack/components/ResourceQuotaEmptyState/index.js Outdated Show resolved Hide resolved
@bastian-src bastian-src force-pushed the feature/link_welcome_to_foreman_doc branch 2 times, most recently from 24f9d5e to b6c62ce Compare January 27, 2025 11:02
bastian-src and others added 3 commits January 27, 2025 15:24
Link from Resource Quota welcome page to Foreman docs on limiting
host resources:

https://docs.theforeman.org/nightly/Administering_Project/index-katello.html#limiting-host-resources

Co-authored-by: Maximilian Kolb <[email protected]>
* Add dependency @testing-library/user-event to simulate user
  click events during tests
* Update package-lock.json with new dependency
* Add snapshot test
* Add functional test for Modal opening mechanism
* Add test_helper (cc foreman_ansible) for mocking React/Redux contexts.
@bastian-src bastian-src force-pushed the feature/link_welcome_to_foreman_doc branch from b6c62ce to b696166 Compare January 27, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to Foreman docs from WebUI
2 participants