Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against newer foreman #92

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Test against newer foreman #92

merged 1 commit into from
Dec 20, 2023

Conversation

m-bucher
Copy link
Member

@m-bucher m-bucher commented Dec 8, 2023

No description provided.

maximiliankolb
maximiliankolb previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me. Where did you get the node version from?

@m-bucher
Copy link
Member Author

The node version is taken from the foreman spec-file: https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/foreman/foreman/foreman.spec#L320

maximiliankolb
maximiliankolb approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@m-bucher m-bucher merged commit 4d19b02 into master Dec 20, 2023
8 checks passed
@m-bucher m-bucher deleted the upgrade_test_env branch December 20, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bucher @maximiliankolb