Retail: Revised use of Colors since in some cases it could result in …

…an infinite metatable recursive reference to itself (fixes #1720) (fixes #1668)

lib/Colors.lua

@@ -5,7 +5,7 @@ local _, app = ...;
 -- Encapsulates the raw Color strings used throughout ATT
 
 -- Color |cAARRGGBB values used throughout ATT
-app.Colors = {
+app.DefaultColors = {
 	ATT = "ffb4b4ff",
 	Raid = "ffFF7D01",	-- Raid chat color
 	SourceIgnored = "ffd15517",
@@ -39,8 +39,14 @@ app.Colors = {
 	White = "ffFFFFFF",
 };
 
+app.SetCustomColors = function(colorTable)
+	app.Colors = setmetatable(colorTable or {}, {__index = app.DefaultColors})
+end
+
+app.SetCustomColors()
+
 app.ccColors = {};
-for k,v in pairs (app.Colors) do
+for k,v in pairs (app.DefaultColors) do
 	app.ccColors[k] = "|c"..v;
 end;
 

src/Settings/Retail Settings.lua

@@ -235,9 +235,8 @@ settings.Initialize = function(self)
 	local colors = settings:Get("Window:CustomColors") or {}
 	-- make sure the table reference is actually assigned back to be saved
 	settings:Set("Window:CustomColors",colors)
-	setmetatable(colors, { __index = app.Colors });
-	-- replace the direct table with a metatable of the original colors
-	app.Colors = colors;
+	-- replace the direct table with a metatable of the user's colors & Default fallbacks
+	app.SetCustomColors(colors)
 
 	-- Assign the preset filters for your character class as the default states
 	if not AllTheThingsSettingsPerCharacter then AllTheThingsSettingsPerCharacter = {} end