Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong zhCN translation in Primal Storms headers, which using spell names #1864

Closed
gjfLeo opened this issue Dec 14, 2024 · 5 comments
Closed
Assignees
Labels
Localization error Errors in any non-American English strings.

Comments

@gjfLeo
Copy link
Contributor

gjfLeo commented Dec 14, 2024

What flavo(u)r(s) of WoW are you using?

Retail

Which server realm(s) are you in?

CN

What build number of WoW?

No response

What version of ATT?

Latest release

What build number of ATT?

No response

What isn't working? What was supposed to happen?

Currently the element type headers in Primal Storm use spell names, and some of them are incorrect in zhCN locales.

EN Current Should be ... (which in achievement names)
Firestorm spell:368847 (火焰风暴) 火焰风暴 ✔
Sandstorm spell:252264 (沙尘暴) 沙暴 👀(ok but not accurate)
Snowstorm spell:373198 (雪暴) 雪暴 ✔
Thunderstorm spell:77556 (雷霆践踏) 雷暴 ❌(totally two meanings)

Screenshot

No response

Steps to reproduce the behavior.

Use zhCN locale, go to main list - 特色更新(Expansion Feature) - 巨龙时代(DF) - 原始风暴(Primal Storm)

Are you experiencing any lua errors?

No response

Anything else?

I looked into some spells, maybe useful:

  • Spell 238515 has same translation with spell 77556 in every locales except Chinese and Italian, and has a different spell icon. I'm not sure which one is proper in Italian.
    • 238515: Thunderstorm / 雷暴(✔) / Tempesta Tonante
    • 77556: Thunderstorm / 雷霆践踏(❌) / Esplosione Tonante
    • Achievement example: Thunderstorms in Thaldraszus / 索德拉苏斯的雷暴 / Tempeste di Fulmini a Thaldraszus
  • There's no spell named "沙暴" in zhCN.
@gjfLeo gjfLeo added the Addon Bug Something is not working properly with the addon. label Dec 14, 2024
@gjfLeo gjfLeo changed the title Wrong zhCN translation in Primal Storms headers Wrong zhCN translation in Primal Storms headers, which using spell names Dec 14, 2024
@NORPG NORPG self-assigned this Dec 14, 2024
@NORPG
Copy link
Member

NORPG commented Dec 14, 2024

Perhaps using spellnames is not the best choice, but currently ATT does not seem to provide a direct method to obtain localized object IDs.

@NORPG
Copy link
Member

NORPG commented Dec 14, 2024

https://wago.tools/db2/SpellName?filter[ID]=77556&page=1&locale=zhCN
The wago tools is another wow database. If there are tables here, ATT may be able to quote them directly.

@NORPG NORPG added Localization error Errors in any non-American English strings. and removed Addon Bug Something is not working properly with the addon. labels Dec 14, 2024
@gjfLeo
Copy link
Contributor Author

gjfLeo commented Dec 14, 2024

Perhaps using spellnames is not the best choice, but currently ATT does not seem to provide a direct method to obtain localized object IDs.

The "Thunderstorm" here is neither an object nor a spell, I know there's not an exists translation to access in API. The problem is that the current alternative spell:77556 does not share a proper name in zhCN. Maybe we should use another spell, or make this can be localized manually.

@NORPG NORPG added To Do List Stuff that is on the To Do List and removed To Do List Stuff that is on the To Do List labels Dec 16, 2024
NORPG added a commit that referenced this issue Dec 25, 2024
@NORPG NORPG closed this as completed Dec 25, 2024
@NORPG
Copy link
Member

NORPG commented Dec 25, 2024

I fixed multilingual translation errors by customizing headers, and it will be resolved in the next release.

@NORPG
Copy link
Member

NORPG commented Dec 25, 2024

I directly copied the string provided by Wago, but I am not sure if it is the correct GB 2312 characters.
If not, please help me modify it and submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization error Errors in any non-American English strings.
Projects
None yet
Development

No branches or pull requests

2 participants