Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factions in profession minilist #722

Closed
Molkree opened this issue Mar 12, 2021 · 8 comments
Closed

Factions in profession minilist #722

Molkree opened this issue Mar 12, 2021 · 8 comments
Assignees
Labels
Addon Bug Something is not working properly with the addon.

Comments

@Molkree
Copy link
Collaborator

Molkree commented Mar 12, 2021

image

I think it appears due to this daily quest:
image

@Molkree Molkree added the Addon Bug Something is not working properly with the addon. label Mar 12, 2021
@ImUnicke ImUnicke self-assigned this Mar 12, 2021
@ImUnicke
Copy link
Collaborator

I'm not sure why this shows in here, but it remains even with the Collectible As Cost logic modified to always return false, so it may have been happening from before that.

@Molkree
Copy link
Collaborator Author

Molkree commented Mar 12, 2021

@ImUnicke, yes, I went as far back as version 2.0.9 (first SL version, BfA is incompatible now) and it was always there, we just haven't noticed.

@ImUnicke
Copy link
Collaborator

I feel like the best way to adjust this functionality is to only pull 'collectible' Things which require that Profession into the respective Profession list, instead of everything tagged for that Profession and allowing the List to filter itself based on the user's current filters.
So if I enable "Collect Repeatable Quests" I get this:
image
And if it is opened while disabled:
image

The Profession list data will only re-update itself if you open a different Profession though, so there's that caveat.

@Molkree Molkree changed the title Netherwing faction in Skinning minilist Factions in profession minilist Mar 29, 2021
@Molkree
Copy link
Collaborator Author

Molkree commented Mar 29, 2021

Still the case sometimes. Example, Cooking->Outdoor zones->Northrend->Dalaran->Faction->Faction #1124. I think it is Horde equivalent of The Silver Covenant, you'll need Account Mode to see it on your Alliance character.
User report
image

Seeing this on 8ad7c53.

@Molkree Molkree reopened this Mar 29, 2021
@DFortun81
Copy link
Member

I always sort of hated having quests nested underneath factions. I feel like that'd be the true solution to this "problem".

@Molkree
Copy link
Collaborator Author

Molkree commented Mar 31, 2021

In the case of Northrend Dalaran it is a vendor, not quests.

image

@Valazdin
Copy link
Contributor

can we close this issue, it woud seem that you restructured professions and factions are not under them any more.

@Molkree
Copy link
Collaborator Author

Molkree commented Jun 27, 2021

Nothing changed, faction is still in the list

image

Exodius pushed a commit to Exodius/AllTheThings that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addon Bug Something is not working properly with the addon.
Projects
None yet
Development

No branches or pull requests

4 participants