Logic realignment #1011
Merged
Logic realignment #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors from row summaries
…ion of functionality Localized a bunch of functions which are only used by other local functionality Couple additional minor local usages instead of repeated table accesses
Fixed bug with ArrayAppend when passing in a nil
Exodius
pushed a commit
to Exodius/AllTheThings
that referenced
this pull request
Nov 7, 2024
* Removed whitespace that notepad++ likes to add * Some simplification and differentiation for tooltip completion indicators from row summaries * Some partial cost logic improvements * Huge realignment of Type libraries to improve localization/consolidation of functionality Localized a bunch of functions which are only used by other local functionality Couple additional minor local usages instead of repeated table accesses * More clean up * More various clean up adjustments Fixed bug with ArrayAppend when passing in a nil * Fixed non-callback quest refresh function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much as far as 'changes' but mostly re-alignment of code structures to better handle memory management of used variables.
Many variables were able to be localized and removed from being attached to the AllTheThings global table.
Additionally, there were various performance improvements due to reduced table key lookups and cost logic being re-implemented further.
Tooltip collection text is actually generated properly for tooltips which are not generated by an ATT window.