Massimport objective data for Kalimdor zones #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funjoker
force-pushed
the
master
branch
3 times, most recently
from
f8f70fc to
6cf43fc
Compare
DFortun81
approved these changes
Jul 6, 2024
funjoker
commented
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Durotar.lua
Outdated
Show resolved
Hide resolved
funjoker
commented
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Durotar.lua
Outdated
Show resolved
Hide resolved
funjoker
commented
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Ashenvale.lua
Outdated
Show resolved
Hide resolved
DFortun81
reviewed
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Ashenvale.lua
Outdated
Show resolved
Hide resolved
funjoker
commented
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Ashenvale.lua
Outdated
Show resolved
Hide resolved
DFortun81
reviewed
Jul 8, 2024
| @@ -1567,6 +1772,12 @@ root(ROOTS.Zones, m(KALIMDOR, { | |||
| ["timeline"] = { ADDED_4_0_3 }, | |||
| ["races"] = HORDE_ONLY, | |||
| ["groups"] = { | |||
| objective(2, { -- 0/4 Blackmaw Warrior slain | |||
There was a problem hiding this comment.
This appears to be missing objective(1), might be able to review a video or playthrough the quest to see if a particular interaction with an object causes that objective to trigger (such as aportal)
There was a problem hiding this comment.
well first you use item then talk to npc and get teleported and then talk to npc there to trigger a fight
DFortun81
reviewed
Jul 8, 2024
DFortun81
reviewed
Jul 8, 2024
DFortun81
reviewed
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Dustwallow Marsh.lua
Show resolved
Hide resolved
DFortun81
reviewed
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Dustwallow Marsh.lua
Show resolved
Hide resolved
DFortun81
reviewed
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Dustwallow Marsh.lua
Outdated
Show resolved
Hide resolved
DFortun81
reviewed
Jul 8, 2024
.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/Dustwallow Marsh.lua
Outdated
Show resolved
Hide resolved
Exodius
pushed a commit
to Exodius/AllTheThings
that referenced
this pull request
Nov 7, 2024
Massimport objective data for Kalimdor zones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massimporting standard quest objectives (loot item and kills) for Kalimdor zones.
ATM still a draft, but i want to give some time to review already