Retail: Fix shaman class hall's version of Firelands showing Things from Mount Hyjal. #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as sub-zone of Mount Hyjal
…nds Scenario to this scenario
…yjal-data Retail/fix legion firelands hyjal data
ImUnicke
reviewed
Jan 21, 2025
.contrib/Parser/DATAS/06 - Expansion Features/06 Legion/Legion Class Halls/Shaman/Firelands.lua
Show resolved
Hide resolved
ImUnicke
previously requested changes
Jan 21, 2025
…yjal-data Retail: Move shaman class hall's Firelands to under EF>Class Hall>Shaman
|
@ImUnicke I've updated the Result now is: |
DFortun81
dismissed
ImUnicke’s stale review
I think we've come to a good conclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this issue, the Shaman class hall's version of Firelands (a scenario) was showing Things to be gained from Mount Hyjal while this instance of Firelands has 0 connections to that zone.
New header for this version of Firelands is created to remain in line with ATT's look and feel and to prevent a "default" header from showing.
I've personally tested this implementation on two (separate) shamans both in the class hall version of Firelands as well as the actual raid and did not find inconsistencies.