Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized object names #727

Merged
merged 23 commits into from
Mar 18, 2021
Merged

Localized object names #727

merged 23 commits into from
Mar 18, 2021

Conversation

Molkree
Copy link
Collaborator

@Molkree Molkree commented Mar 14, 2021

  • Review all changes, I just dumped everything now w/o checking much
  • Some strings in enUS have prepended coloured "Step X: " or whatever, will probably need to add it manually
  • Deal with those weird GetSpellInfo lines, what are they?
  • Upload scraping script
  • Deal with those weird pages that don't have heading I used to get the name from, maybe change to another tag/etc
  • Write new script that pulls and adds localized names after contrib commits new object name(s) in enUS, at least add TODO if no translation on Wowhead yet
  • Run it in release separate workflow

@Molkree Molkree marked this pull request as ready for review March 18, 2021 21:45
@Molkree Molkree merged commit b2efcda into master Mar 18, 2021
@Molkree Molkree deleted the localize_object_names branch March 18, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant