Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method 1 : pin Setuptools==69.5.1 #15882

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix method 1 : pin Setuptools==69.5.1 #15882

merged 1 commit into from
May 28, 2024
+1 −0

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 25, 2024 •
edited
Loading

Description

ImportError: cannot import name 'packaging' from 'pkg_resources' (venv\lib\site-packages\pkg_resources\__init__.py)

the pkg_resources package was deprecated
https://github.com/pypa/setuptools/blob/5cbf12a9b63fd37985a4525617b46576b8ac3a7b/pkg_resources/__init__.py#L16-L17
and in setuptools=70.0.0 there was a change that breaks packeages that imports uses pkg_resources.packaging

a quick fix FOR NOW would be to pin Setuptools==69.5.1

the real fix would be to update all dependencies to not use the deprecated pkg_resources

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 25, 2024 05:49
This was referenced May 25, 2024
Closed
Closed
@AUTOMATIC1111 AUTOMATIC1111 merged commit 759f396 into dev May 28, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the setuptools==69.5.1 branch May 28, 2024 18:16
w-e-w added a commit that referenced this pull request May 28, 2024
@w-e-w
#15883 -> #15882
6f3bd99
@w-e-w w-e-w mentioned this pull request May 28, 2024
Merged
4 tasks
w-e-w added a commit that referenced this pull request May 28, 2024
@w-e-w
#15883 -> #15882
8d6f741
This was referenced May 29, 2024
Closed
Closed
AUTOMATIC1111 added a commit that referenced this pull request Jun 8, 2024
@AUTOMATIC1111
Merge pull request #15907 from AUTOMATIC1111/fix-change-log
0c0d71a 
fix changelog #15883 -> #15882
@ionite34 ionite34 mentioned this pull request Jun 19, 2024
Closed
@w-e-w w-e-w mentioned this pull request Jun 19, 2024
Open
1 task
@w-e-w w-e-w mentioned this pull request Jul 29, 2024
Open
6 tasks
ruchej pushed a commit to ruchej/stable-diffusion-webui that referenced this pull request Sep 30, 2024
@w-e-w @ruchej
AUTOMATIC1111#15883 -> AUTOMATIC1111#15882
70e352f
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w-e-w @AUTOMATIC1111