-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use onMouseDown
to increase perceived performance
#564
Draft
AVGVSTVS96
wants to merge
5
commits into
voidZero
Choose a base branch
from
mouseDown
base: voidZero
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new `handleMouseDown` utility function to handle `onMouseDown` events Implement in `Header` and `ProjectsDropdown`
Refactor `CommandMenu`, separate `CommandGroups` into their own components
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e1ccf25
to
5e24ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Use
onMouseDown
to increase perceived performanceCreate new
handleMouseDown
utility function to handleonMouseDown
eventsImplement in
Header
andProjectsDropdown
feat: Implement handleMouseDown in
CommandMenu
andSideMenu
Refactor
CommandMenu
, separateCommandGroups
into their owncomponents