feat: Add fish shell option, put optional shells in shared/shells/
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 11, 2024
AVGVSTVS96
changed the title
in shared/shells/`in shared/shells/
AVGVSTVS96
force-pushed
the
shells
branch
2 times, most recently
from
fa33b99 to
0bb48c9
Compare
AVGVSTVS96
force-pushed
the
homebrew
branch
2 times, most recently
from
242ebd3 to
fbce60b
Compare
AVGVSTVS96
force-pushed
the
shells
branch
2 times, most recently
from
6859d0a to
8cc99b1
Compare
AVGVSTVS96
force-pushed
the
shells
branch
2 times, most recently
from
b40532c to
cd6f677
Compare
Draft
- Move zsh config to `modules/shared/shells/zsh.nix`, add fish config to `modules/shared/shells/fish.nix` - Make each shell optional, add activeShell option definition in `shared/default.nix` for tracking the currently enabled shell. This is set in each shells/ file, then used in programs.nix to enable shell specific integrations with `isZsh` or `isFish`
Use conditional to determine fzf `fileWidgetOptions` syntax
AVGVSTVS96
force-pushed
the
graphite-base/5
branch
from
7d20563 to
858805f
Compare
Remove `$EDITOR` definition from `shells/zsh.nix`, set as `environment.variables` in `shared/default.nix`. This sets the var globally.
Merge activity
|
This was referenced Nov 20, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules/shared/shells/zsh.nix, add fish config tomodules/shared/shells/fish.nixshared/default.nixfor tracking the currently enabled shell. This isset in each shells/ file, then used in programs.nix to enable shell
specific integrations with
isZshorisFish$EDITORdefinition toshared/default.nix, makes it global, instead of shell specificfileWidgetOptionswith conditional that uses fish syntax if using fish, else bashknownUserswithuidto enable nix managed shell in nix-darwinknownUsersmay not be the best way to do this -users.users.<name>.shelldoes not update the user's shell LnL7/nix-darwin#811 (comment)