Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for commons.util.StringUtil.limitString() #137

Merged

Conversation

mingyi456
Copy link

No description provided.

@mingyi456 mingyi456 added this to the v1.4 milestone Oct 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #137 (078a1a5) into master (19e2c3a) will increase coverage by 0.54%.
The diff coverage is 75.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
+ Coverage     58.14%   58.68%   +0.54%     
- Complexity      563      601      +38     
============================================
  Files           110      121      +11     
  Lines          2377     2561     +184     
  Branches        229      251      +22     
============================================
+ Hits           1382     1503     +121     
- Misses          916      966      +50     
- Partials         79       92      +13     
Impacted Files Coverage Δ
...ava/seedu/address/logic/commands/ClearCommand.java 54.54% <ø> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/ListCommand.java 70.00% <ø> (ø)
...java/seedu/address/logic/commands/UndoCommand.java 57.14% <ø> (ø)
.../java/seedu/address/logic/parser/ArgumentType.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/TaskCommandParser.java 0.00% <0.00%> (ø)
...ser/exceptions/ArgumentContainsSlashException.java 0.00% <0.00%> (ø)
...in/java/seedu/address/storage/JsonAdaptedTask.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/EditTaskDialog.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4dd0d...078a1a5. Read the comment docs.

Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffsieu jeffsieu merged commit 8c4e5eb into AY2122S1-CS2103-F09-2:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants