Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timestamp UG, format #140

Merged
merged 6 commits into from
Nov 2, 2021

Conversation

koh-jx
Copy link

@koh-jx koh-jx commented Oct 30, 2021

No description provided.

Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the GUI also needs to be changed to display in dd-mm-yyyy. But that could be done in a different PR.

@jeffsieu jeffsieu added this to the v1.4 milestone Oct 30, 2021
@koh-jx
Copy link
Author

koh-jx commented Oct 30, 2021

I believe the GUI also needs to be changed to display in dd-mm-yyyy. But that could be done in a different PR.

This is done in the Timestamp#toString()

@codecov-commenter
Copy link

Codecov Report

Merging #140 (4de78b2) into master (7f739b6) will increase coverage by 0.36%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
+ Coverage     58.41%   58.78%   +0.36%     
- Complexity      599      602       +3     
============================================
  Files           121      121              
  Lines          2561     2562       +1     
  Branches        251      251              
============================================
+ Hits           1496     1506      +10     
+ Misses          975      964      -11     
- Partials         90       92       +2     
Impacted Files Coverage Δ
.../main/java/seedu/address/model/task/Timestamp.java 61.11% <66.66%> (+14.05%) ⬆️
...in/java/seedu/address/commons/util/StringUtil.java 89.28% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f739b6...4de78b2. Read the comment docs.

@jeffsieu
Copy link

jeffsieu commented Nov 2, 2021

@koh-jx Conflicts need to be resolved.

@jeffsieu jeffsieu merged commit 5de5564 into AY2122S1-CS2103-F09-2:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment