Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear undo #157

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Conversation

koh-jx
Copy link

@koh-jx koh-jx commented Oct 30, 2021

Fixes #109.
Due to setAddressBook(), which calls AddressBook#resetData() and resets the PersonList rather than the AddressBook itself.

Also fixed a bug where clear does not update the presence of contacts in tasks.

@codecov-commenter
Copy link

Codecov Report

Merging #157 (99bcbf1) into master (83edc0c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #157      +/-   ##
============================================
+ Coverage     58.68%   58.70%   +0.01%     
  Complexity      602      602              
============================================
  Files           121      121              
  Lines          2561     2562       +1     
  Branches        251      251              
============================================
+ Hits           1503     1504       +1     
  Misses          966      966              
  Partials         92       92              
Impacted Files Coverage Δ
...ava/seedu/address/logic/commands/ClearCommand.java 54.54% <100.00%> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 82.02% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83edc0c...99bcbf1. Read the comment docs.

@koh-jx koh-jx linked an issue Oct 30, 2021 that may be closed by this pull request
Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffsieu jeffsieu merged commit b166319 into AY2122S1-CS2103-F09-2:master Oct 30, 2021
@jeffsieu jeffsieu added this to the v1.4 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Undo does not undo Clear Command [PE-D] Undo command doesn't work after clear command
3 participants