Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #189

Merged
merged 6 commits into from
Nov 4, 2021
Merged

Add more tests #189

merged 6 commits into from
Nov 4, 2021

Conversation

koh-jx
Copy link

@koh-jx koh-jx commented Nov 3, 2021

Adding various tests

  • Find task, undo for find
  • Cases with multiple arguments
  • Slash found in argument
  • Added contacts in Test Builders and CommandTestUtil

Fix bugs:

  • FindTaskCommand with no arguments not clearing filters as intended
  • FindTaskCommand throwing NPE if no previous predicate exists (null)
  • "Listed 1 tasks" not making grammatical sense: changed to "Listed 1 task(s)" (Same with persons)
  • Undo message for FindTask and Find Commands not displaying the correct previous amounts of tasks/persons listed.

Fix bugs regarding
- FindTaskCommand with no arguments not clearing filters
- "Listed 1 tasks" changed to "Listed 1 task(s)" (Same with persons)
- Undo string for FindTask and Find Commands now display the correct
previous amounts of tasks/persons listed.
@koh-jx koh-jx marked this pull request as draft November 3, 2021 09:50
@koh-jx koh-jx marked this pull request as ready for review November 4, 2021 07:34
@codecov-commenter
Copy link

Codecov Report

Merging #189 (524c85c) into master (fc864e9) will increase coverage by 0.92%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
+ Coverage     60.82%   61.74%   +0.92%     
- Complexity      680      693      +13     
============================================
  Files           123      123              
  Lines          2757     2766       +9     
  Branches        264      266       +2     
============================================
+ Hits           1677     1708      +31     
+ Misses          985      964      -21     
+ Partials         95       94       -1     
Impacted Files Coverage Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
...u/address/logic/commands/task/FindTaskCommand.java 82.35% <60.00%> (+6.35%) ⬆️
...java/seedu/address/logic/commands/FindCommand.java 88.23% <75.00%> (+5.88%) ⬆️
...u/address/logic/commands/task/EditTaskCommand.java 97.97% <0.00%> (+1.01%) ⬆️
.../seedu/address/logic/parser/ArgumentTokenizer.java 93.10% <0.00%> (+3.44%) ⬆️
...va/seedu/address/logic/parser/CommandArgument.java 92.59% <0.00%> (+3.70%) ⬆️
...ress/model/task/TaskContainsKeywordsPredicate.java 85.71% <0.00%> (+7.14%) ⬆️
...in/java/seedu/address/logic/parser/ParserUtil.java 98.03% <0.00%> (+9.80%) ⬆️
...rc/main/java/seedu/address/model/task/Contact.java 66.66% <0.00%> (+16.66%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc864e9...524c85c. Read the comment docs.

Copy link

@mingyi456 mingyi456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyi456 mingyi456 merged commit d733c65 into AY2122S1-CS2103-F09-2:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants