Prevent overlap of task title and checkbox, set min length of task panel #197
+39
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: (31 commits) Fix PR issues Change ... to … Fix grammar Fix grammar Improve command parsing and error handling Fix AY2122S1-CS2103-F09-2#134, AY2122S1-CS2103-F09-2#135, AY2122S1-CS2103-F09-2#136, AY2122S1-CS2103-F09-2#143 Fix AY2122S1-CS2103-F09-2#158 Fix AY2122S1-CS2103-F09-2#151 Fix AY2122S1-CS2103-F09-2#125, AY2122S1-CS2103-F09-2#139 Fix AY2122S1-CS2103-F09-2#128 Fix AY2122S1-CS2103-F09-2#112, AY2122S1-CS2103-F09-2#110 Fix clear undo Update Model javadoc Fix KeywordTaskFilter hasConflictWith method Change execute and undo methods Fix ListTaskCommand Deconflict task filters Add test cases for `commons.util.StringUtil.limitString()` Bug fix: DoneTaskCommand undo/redo Remove unused import in DoneTaskFilter ...
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: (29 commits) Fix test cases Add isDone to EditTaskDescriptor Fix set task command feat: Add starting tasks on init Fix checkstyle again Add various tests, redo test Add SetTaskCommand undo test Fix checkstyle Add tests Add EOF to Fonts.css Absorb enter in EditTaskDialog Update help window Remove duplicate line in ModelManager Remove trailing whitespace Fix task filter bugs Update model docs Fix GUI task editing not being undoable Refactor Command to UndoableCommand Update default button css Remove command input border ...
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
============================================
- Coverage 61.74% 61.70% -0.05%
Complexity 693 693
============================================
Files 123 123
Lines 2766 2768 +2
Branches 266 266
============================================
Hits 1708 1708
- Misses 964 966 +2
Partials 94 94
Continue to review full report at Codecov.
|
yeppog
previously requested changes
Nov 6, 2021
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: (28 commits) Fix trailing whitespace at EOF Fix trailing whitespaces Fix stuff Add PPP Fix checkstyle Skeleton for PPP Changes the UG Remove whitespaces Add contacts DG Update UI png and minor edits to AboutUs and index Update error message Add Contacts in UCP use cases Grammar fix Fix broken links Update EditTaskCommand Docs Pull from upstream Update use cases docs: Update PPP for yeppog Add monospace to PR link Update PPP Jeff Sieu ...
# Conflicts: # src/main/java/seedu/address/ui/TaskCard.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.