Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete Task Command #44

Merged

Conversation

mingyi456
Copy link

Closes #27.

* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp:
  Add use cases pertaining to existing AB3 features to the Developer Guide.
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp:
  docs: Update more user stories
  docs: Update user stories
  docs: Fix table of contents not loading
  docs: Update front page for product website
  Update Developr Guide
  Update User Guide for V1.2
  Revert "Revert "Update Release link in README.md""
  Add to .gitignore
  Revert "Update Release link in README.md"
  Update Release link in README.md
  Update AboutUs.md and Weilin's portfolio
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp:
  Fix checkstyle
  Fix AddTaskCommand docs
  Improve documentation for task add command
  Fix model test stub
  Fix checkstyle
  Add AddTaskCommand
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp:
  Fix AddCommandTest
  Add done command to UG
  Improve Done Command docs
  Add basic done command
@mingyi456 mingyi456 requested a review from jeffsieu October 9, 2021 17:25
# Conflicts:
#	src/main/java/seedu/address/logic/parser/TaskCommandParser.java
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #44 (0b7e182) into master (9785312) will decrease coverage by 0.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     68.22%   67.34%   -0.88%     
  Complexity      399      399              
============================================
  Files            78       80       +2     
  Lines          1306     1323      +17     
  Branches        129      130       +1     
============================================
  Hits            891      891              
- Misses          382      399      +17     
  Partials         33       33              
Impacted Files Coverage Δ
...address/logic/commands/task/DeleteTaskCommand.java 0.00% <0.00%> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <ø> (ø)
.../seedu/address/logic/parser/TaskCommandParser.java 0.00% <0.00%> (ø)
...ess/logic/parser/task/DeleteTaskCommandParser.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 92.30% <0.00%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9785312...0b7e182. Read the comment docs.

Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But some minor documentation/formatting changes would be good.

wlren
wlren previously approved these changes Oct 11, 2021
Copy link

@wlren wlren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeffsieu
jeffsieu previously approved these changes Oct 11, 2021
@wlren wlren dismissed stale reviews from jeffsieu and themself via 6bd37ce October 11, 2021 14:31
wlren
wlren previously approved these changes Oct 11, 2021
Copy link

@wlren wlren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@wlren wlren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wlren wlren merged commit 485a14c into AY2122S1-CS2103-F09-2:master Oct 11, 2021
@mingyi456 mingyi456 added this to the v1.2 milestone Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "task" delete command
4 participants