-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete Task Command #44
Add Delete Task Command #44
Conversation
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Add NFRs, glossary
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Add use cases pertaining to existing AB3 features to the Developer Guide.
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: docs: Update more user stories docs: Update user stories docs: Fix table of contents not loading docs: Update front page for product website Update Developr Guide Update User Guide for V1.2 Revert "Revert "Update Release link in README.md"" Add to .gitignore Revert "Update Release link in README.md" Update Release link in README.md Update AboutUs.md and Weilin's portfolio
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Fix checkstyle Fix AddTaskCommand docs Improve documentation for task add command Fix model test stub Fix checkstyle Add AddTaskCommand
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Fix AddCommandTest Add done command to UG Improve Done Command docs Add basic done command
# Conflicts: # src/main/java/seedu/address/logic/parser/TaskCommandParser.java
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
============================================
- Coverage 68.22% 67.34% -0.88%
Complexity 399 399
============================================
Files 78 80 +2
Lines 1306 1323 +17
Branches 129 130 +1
============================================
Hits 891 891
- Misses 382 399 +17
Partials 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But some minor documentation/formatting changes would be good.
src/main/java/seedu/address/logic/commands/task/DeleteTaskCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/task/DeleteTaskCommandParser.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/task/DeleteTaskCommandParser.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/task/DeleteTaskCommandParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…i456/tp into delete-command
Merge branch 'branch-Delete-Task-Command' of https://github.com/mingy…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #27.