Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command history #79

Merged
merged 12 commits into from
Oct 27, 2021

Conversation

yeppog
Copy link

@yeppog yeppog commented Oct 23, 2021

Allow for filtering through previously executed commands through the CLI through the arrow keys (up and down) as navigation.

Closes #64 .

@yeppog yeppog added this to the v1.3 milestone Oct 23, 2021
@yeppog yeppog added the type.Enhancement An enhancement to an existing story label Oct 23, 2021
- Implemented storage for the latest typed command
- Fix bug where certain lines are iterated through multiple times
@yeppog yeppog marked this pull request as ready for review October 25, 2021 10:27
Copy link

@koh-jx koh-jx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err

@yeppog
Copy link
Author

yeppog commented Oct 25, 2021

resolved @koh-jx

koh-jx
koh-jx previously approved these changes Oct 25, 2021
@koh-jx
Copy link

koh-jx commented Oct 25, 2021

resolved @koh-jx

Eh wait havent commit yet LOL

@koh-jx koh-jx dismissed their stale review October 25, 2021 12:04

Haven't commit

@jeffsieu
Copy link

@yeppog Is this ready for review?

@yeppog yeppog force-pushed the add-command-history branch from 30ddc0d to 9732dca Compare October 27, 2021 15:50
@codecov-commenter
Copy link

Codecov Report

Merging #79 (6f9dcc4) into master (896c1a9) will increase coverage by 0.83%.
The diff coverage is 57.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     57.30%   58.14%   +0.83%     
- Complexity      555      563       +8     
============================================
  Files           110      110              
  Lines          2342     2377      +35     
  Branches        225      229       +4     
============================================
+ Hits           1342     1382      +40     
+ Misses          921      916       -5     
  Partials         79       79              
Impacted Files Coverage Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
src/main/java/seedu/address/ui/CommandBox.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 39.13% <25.00%> (-1.35%) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 81.60% <50.00%> (-1.13%) ⬇️
.../main/java/seedu/address/storage/InputHistory.java 90.00% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896c1a9...6f9dcc4. Read the comment docs.

Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffsieu jeffsieu merged commit 19e2c3a into AY2122S1-CS2103-F09-2:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a student, I can use the arrow up and down key to view previous commands that were executed
4 participants