Add DeleteTaskCommand DG
#80
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Fix test cases checkstyle for real Fix tests checkstyle Fix test cases Fix checkstyle again Fix checkstyle fix: Remove copy URL button fix: Trailing whitespace in HelpWindow.fxml add: User command list to help window update: Change help window URL update: Change help window to have a clickable hyperlink to open guide Add basic task list GUI
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Update DeleteCommandParser.java Implement requested changes. Fix checkstyle. Implement the deletion of tasks from the task list. Bug fix, fix checkstyle and test Fix checkstyle errors Refactor DoneTaskCommand Add EditTaskCommand Add initial application hooks for `DeleteTaskCommand`
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Debug Storage loading Checkstyle Fixes Checkstyle and minor changes Model changes for incorporating Task storage Add JSON support for tasks Add TaskList methods to Storage TaskList storage classes Update User Prefs: Json classes for Task Change boolean naming
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Fix CI for testing Fix Checkstyle
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Fix slash to focus Add TaskCommandParser, AddTaskCommand tests Improve TaskFilter-related docs Fix test cases Fix checkstyle Update task filters when necessary Add task filters and improve task card Resolve merge conflicts Add slash to focus on command input ci: Update gradle.yml to do whitespace check last. Fix checkstyle Add EditTaskCommand tests Fix checkstyle Add test cases, change Model setTaskAtIndex Fix GuiAction-related docs Fix AddCommandTest Remove system print call Fix GUI checkbox
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Add preamble check for task lsit Add task list command Change version number for release Enable assertions Fix one test error Change to static imports for ParserTests Fix ONE checkstyle error Resolve PR comments Update developer guide text Update developer guide UML Update Userguide Fix checkstyle violations Bug fix Remove hasDone/hasUndone Bug fix for filters, purge tasks Add purge task command Change equals format to match others Remove system print messages
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: Resolve DG issues Update DevGuide with task filter docs
* 'master' of https://github.com/AY2122S1-CS2103-F09-2/tp: (38 commits) fix: Touch up chore: Minor renaming of docs and variables test: Cleanup to pass unit tests style: Cleanup to pass Checkstyle docs: Minor cleanup add: Implement undo for ListTask add: Add super canUndo() and canExecute() fix: Remove system.out.println fix: Change to super for Command test: Fix gradle checkstyle add: Add message usage to Undo docs: Add Undo to DG test: Add simple testing for undo add: Assert non null fix: Shorten undo message fix: Update to factory method for Task copy fix: Implement undo in Logic fix: Rename index add to insertTask feat: Fix mutability issue on Command fix: Fix issue where ctrl + z loops too quickly ...
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage 60.95% 60.95%
Complexity 504 504
=========================================
Files 100 100
Lines 2000 2000
Branches 197 197
=========================================
Hits 1219 1219
Misses 715 715
Partials 66 66 Continue to review full report at Codecov.
|
jeffsieu
reviewed
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.