Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add task GUI #86

Merged
merged 6 commits into from
Oct 27, 2021

Conversation

jeffsieu
Copy link

Tasks can be added using the "New" button and edited by double-clicking or pressing enter on a selected task.

@wlren
Copy link

wlren commented Oct 25, 2021

Oi never compile

Tasks can be added using the "New" button and
edited by double-clicking or pressing enter
on a selected task.
@jeffsieu jeffsieu force-pushed the branch-Add-Task-GUI branch from f05a155 to d203527 Compare October 25, 2021 13:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #86 (f370699) into master (b4f5101) will decrease coverage by 3.36%.
The diff coverage is 0.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     62.03%   58.66%   -3.37%     
  Complexity      535      535              
============================================
  Files           107      108       +1     
  Lines          2057     2175     +118     
  Branches        198      203       +5     
============================================
  Hits           1276     1276              
- Misses          714      832     +118     
  Partials         67       67              
Impacted Files Coverage Δ
src/main/java/seedu/address/ui/DeletableChip.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/EditTaskDialog.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø)
...main/java/seedu/address/ui/TaskFilterChipCell.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/TaskListPanel.java 0.00% <0.00%> (ø)
...c/main/java/seedu/address/ui/TaskListViewCell.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <ø> (ø)
src/main/java/seedu/address/model/task/Task.java 78.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f5101...f370699. Read the comment docs.

Copy link

@yeppog yeppog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but some small styling issues to be fixed

@jeffsieu jeffsieu requested a review from yeppog October 26, 2021 18:59
Copy link

@yeppog yeppog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks good

@jeffsieu jeffsieu added this to the v1.3 milestone Oct 27, 2021
@jeffsieu jeffsieu merged commit 44c0d84 into AY2122S1-CS2103-F09-2:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants