Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Date semantics to Timestamp #89

Merged
merged 18 commits into from
Oct 27, 2021

Conversation

wlren
Copy link

@wlren wlren commented Oct 26, 2021

No description provided.

@wlren wlren added type.Enhancement An enhancement to an existing story priority.Medium labels Oct 26, 2021
@wlren wlren added this to the v1.3 milestone Oct 26, 2021
Copy link

@jeffsieu jeffsieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...

src/main/java/seedu/address/model/task/Timestamp.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Task.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Task.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Timestamp.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Timestamp.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Timestamp.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/task/Timestamp.java Outdated Show resolved Hide resolved
@jeffsieu jeffsieu changed the title Add Regex for Timestamp Add Date semantics to Timestamp Oct 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #89 (c6de922) into master (6e34d06) will decrease coverage by 0.03%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     57.82%   57.79%   -0.04%     
- Complexity      555      567      +12     
============================================
  Files           110      110              
  Lines          2314     2400      +86     
  Branches        221      233      +12     
============================================
+ Hits           1338     1387      +49     
- Misses          898      931      +33     
- Partials         78       82       +4     
Impacted Files Coverage Δ
...in/java/seedu/address/storage/JsonAdaptedTask.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/EditTaskDialog.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/task/Task.java 68.96% <28.57%> (-11.04%) ⬇️
.../main/java/seedu/address/model/task/Timestamp.java 41.17% <46.15%> (-15.97%) ⬇️
...in/java/seedu/address/logic/parser/ParserUtil.java 88.23% <100.00%> (+0.23%) ⬆️
...ddress/logic/parser/task/AddTaskCommandParser.java 100.00% <100.00%> (ø)
...dress/logic/parser/task/EditTaskCommandParser.java 72.97% <100.00%> (-0.72%) ⬇️
...u/address/logic/commands/task/FindTaskCommand.java 56.52% <0.00%> (-43.48%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e34d06...c6de922. Read the comment docs.

@wlren wlren merged commit 933bcab into AY2122S1-CS2103-F09-2:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants