-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Purge undo, cleanup #90
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
============================================
- Coverage 61.98% 61.60% -0.38%
Complexity 535 535
============================================
Files 107 107
Lines 2057 2068 +11
Branches 198 201 +3
============================================
- Hits 1275 1274 -1
- Misses 713 725 +12
Partials 69 69
Continue to review full report at Codecov.
|
…into fix-Purge-Tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
undo Purge
Noted bugs
Tasks with the same name were not added due to the equality of tasks affecting
indexOf()
. This is fixed with Jeff's merged PR bug fix.Refactor Purge
As previously mentioned in the purge PR, the
Model#deleteFilteredTasks
method has been refactored to not take in an arbitraryList<Task>
and assume that it is the Filtered task list. This is becausePurgeTaskCommand
no longer provides its own list but just calls this method.Cleanup undo