Add Grade Parameter to Person #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgoh1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
============================================
+ Coverage 75.26% 75.40% +0.14%
- Complexity 419 433 +14
============================================
Files 71 73 +2
Lines 1338 1403 +65
Branches 126 135 +9
============================================
+ Hits 1007 1058 +51
- Misses 301 310 +9
- Partials 30 35 +5 ☔ View full report in Codecov by Sentry. |
Closed
amanzainal
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Overall:
LGTM! Added comments directly on the code for very minor changes, some general remarks:
- Should we consider separating Test and Grade into two entities?
- Is Checkstyle adhered to? On first glance looks like there's some unnecessary newlines and whitespaces, but I could be wrong
- How do we fix Codecov errors T_T
| */ | ||
| public static final String TEST_NAME_VALIDATION_REGEX = ".+?"; | ||
| public static final String GRADE_VALIDATION_REGEX = "(100|[1-9]?[0-9])$"; | ||
|
|
There was a problem hiding this comment.
(Styling) Extra line here can be removed
| public final String grade; | ||
|
|
||
| /** | ||
| * Constructs an {@code Grade}. |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added grade parameter to person. Syntax for adding a grade would be /g testName: grade
Validation constraints are as follows:
has to be of format testName: grade e.g ca1: 50
testName cannot be empty
grade has to be a number between 0-100