Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter command #54

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

joelgoh1
Copy link

Filters by timeslots
Closes #50

@joelgoh1 joelgoh1 added this to the v1.3 milestone Mar 28, 2024
@joelgoh1 joelgoh1 requested a review from yap-zong-xin March 28, 2024 02:05
@joelgoh1 joelgoh1 self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 83.11258% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 76.11%. Comparing base (305fe23) to head (90dccd2).

Files Patch % Lines
...c/main/java/seedu/address/ui/StudentListPanel.java 0.00% 12 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 10.00% 9 Missing ⚠️
src/main/java/seedu/address/ui/StudentCard.java 0.00% 9 Missing ⚠️
...seedu/address/model/student/UniqueStudentList.java 86.95% 4 Missing and 2 partials ⚠️
.../java/seedu/address/model/timeslots/Timeslots.java 71.42% 2 Missing and 2 partials ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 3 Missing ⚠️
...main/java/seedu/address/model/student/Student.java 88.88% 1 Missing and 1 partial ⚠️
...el/student/TimeslotsContainsKeywordsPredicate.java 84.61% 1 Missing and 1 partial ⚠️
...java/seedu/address/logic/commands/EditCommand.java 97.29% 0 Missing and 1 partial ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 92.85% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     75.15%   76.11%   +0.95%     
- Complexity      435      454      +19     
============================================
  Files            73       76       +3     
  Lines          1413     1453      +40     
  Branches        137      141       +4     
============================================
+ Hits           1062     1106      +44     
+ Misses          314      309       -5     
- Partials         37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yap-zong-xin yap-zong-xin merged commit 5e9bd5f into AY2324S2-CS2103-F08-4:master Mar 28, 2024
5 checks passed
Copy link

@yap-zong-xin yap-zong-xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter command
2 participants