Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit sort command #67

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

joelgoh1
Copy link

@joelgoh1 joelgoh1 commented Apr 4, 2024

No description provided.

@joelgoh1 joelgoh1 requested a review from amanzainal April 4, 2024 15:34
@joelgoh1 joelgoh1 self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.85%. Comparing base (8d9ef36) to head (7f3c1bb).

Files Patch % Lines
.../seedu/address/logic/parser/EditCommandParser.java 0.00% 3 Missing and 1 partial ⚠️
.../model/student/TestNameEqualsKeywordPredicate.java 83.33% 1 Missing and 1 partial ⚠️
...java/seedu/address/logic/commands/SortCommand.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
+ Coverage     69.29%   70.85%   +1.56%     
- Complexity      451      471      +20     
============================================
  Files            78       79       +1     
  Lines          1625     1654      +29     
  Branches        172      177       +5     
============================================
+ Hits           1126     1172      +46     
+ Misses          446      422      -24     
- Partials         53       60       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@amanzainal amanzainal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amanzainal amanzainal merged commit 9333985 into AY2324S2-CS2103-F08-4:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants