Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #108

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Refactor code #108

merged 2 commits into from
Apr 4, 2024

Conversation

shaunlxw
Copy link
Collaborator

@shaunlxw shaunlxw commented Apr 2, 2024

Changes:

  • Index: removed dead code
  • DeleteCommandTest: fix naming of methods and add test

Changes:
* Index: removed dead code
* DeleteCommandTest: fix naming of methods and add test
@shaunlxw shaunlxw requested a review from nuyer April 2, 2024 09:41
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.54%. Comparing base (8f6f617) to head (2a0bbec).

❗ Current head 2a0bbec differs from pull request most recent head 9f06f44. Consider uploading reports for the commit 9f06f44 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     77.47%   77.54%   +0.07%     
+ Complexity      868      734     -134     
============================================
  Files           107       99       -8     
  Lines          2726     2365     -361     
  Branches        338      280      -58     
============================================
- Hits           2112     1834     -278     
+ Misses          509      445      -64     
+ Partials        105       86      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@purivirakarin purivirakarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for updating the code to follow the implementation of using ID instead of index.

@shaunlxw shaunlxw merged commit a6eea1e into AY2324S2-CS2103T-F12-1:master Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants