Update README #11
Merged
Update README #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsia
reviewed
Mar 6, 2024
Co-authored-by: Zhong Qing <[email protected]>
Co-authored-by: Zhong Qing <[email protected]>
|
fixes #10 |
shaunlxw
reviewed
Mar 11, 2024
There was a problem hiding this comment.
LGTM less the minor changes! we are required to acknowledge the original source of the code (https://se-education.org). i'm not sure if the last line in README.md is sufficient as acknowledgement, or if it'll even be there after we change it to fit our project.
| @@ -1,14 +1,35 @@ | |||
| [](https://github.com/se-edu/addressbook-level3/actions) | |||
There was a problem hiding this comment.
need to change this by generating our own workflow badge. not sure if it's only for Java CI only or for all workflow though..
| To begin your journey with NetConnect, simply download the latest release from [here]() and refer to the [User Guide](docs/UserGuide.md) | ||
| for detailed guidance in using the application. | ||
|
|
||
| For the detailed documentation of this project, see the **[Address Book Product Website](https://se-education.org/addressbook-level3)**. |
There was a problem hiding this comment.
i think we need to change the description and link of the documentation to ours
There was a problem hiding this comment.
our group needs to decide whether to use the term "supplier" or "partner"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.