Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor article Title as a class #87

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

H4mes
Copy link
Collaborator

@H4mes H4mes commented Mar 30, 2024

Closes #71

@H4mes H4mes added this to the v1.3b milestone Mar 30, 2024
@H4mes H4mes requested a review from Howlong11 March 30, 2024 14:34
@H4mes H4mes self-assigned this Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 48.85%. Comparing base (ee34dd3) to head (5788cec).

Files Patch % Lines
...c/main/java/seedu/address/model/article/Title.java 0.00% 15 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 3 Missing ⚠️
...java/seedu/address/storage/JsonAdaptedArticle.java 0.00% 3 Missing ⚠️
...c/commands/articlecommands/EditArticleCommand.java 0.00% 1 Missing ⚠️
.../address/logic/parser/AddArticleCommandParser.java 0.00% 1 Missing ⚠️
...main/java/seedu/address/model/article/Article.java 0.00% 1 Missing ⚠️
.../model/article/TitleContainsKeywordsPredicate.java 0.00% 1 Missing ⚠️
...eedu/address/model/util/SampleArticleDataUtil.java 0.00% 1 Missing ⚠️
src/main/java/seedu/address/ui/ArticleCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
- Coverage     49.25%   48.85%   -0.40%     
  Complexity      452      452              
============================================
  Files           112      113       +1     
  Lines          2217     2235      +18     
  Branches        236      238       +2     
============================================
  Hits           1092     1092              
- Misses         1086     1104      +18     
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H4mes H4mes added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic labels Mar 30, 2024
Copy link
Collaborator

@Howlong11 Howlong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@H4mes H4mes merged commit 23c06da into AY2324S2-CS2103T-F12-2:master Mar 31, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor article Title as class
2 participants