Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Scheduler Feature #60

Merged

Conversation

meenulekha
Copy link

Add feature and resolve errors from previous PR

@meenulekha meenulekha added the type.Enhancement New feature or request label Apr 4, 2024
@meenulekha meenulekha added this to the v1.3 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 12.30284% with 556 lines in your changes are missing coverage. Please review.

Project coverage is 61.00%. Comparing base (c849aa5) to head (2096e06).
Report is 5 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/ui/EventWindow.java 0.00% 80 Missing ⚠️
...va/seedu/address/logic/parser/EventParserUtil.java 0.00% 40 Missing ⚠️
...ava/seedu/address/model/event/UniqueEventList.java 34.78% 27 Missing and 3 partials ⚠️
...n/java/seedu/address/storage/JsonAdaptedEvent.java 0.00% 29 Missing ⚠️
.../seedu/address/logic/commands/AddEventCommand.java 0.00% 25 Missing ⚠️
...edu/address/logic/commands/DeleteEventCommand.java 0.00% 25 Missing ⚠️
...edu/address/logic/commands/EventCommandResult.java 0.00% 25 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 20.00% 20 Missing ⚠️
...rc/main/java/seedu/address/ui/EventCommandBox.java 0.00% 20 Missing ⚠️
src/main/java/seedu/address/model/EventBook.java 43.33% 17 Missing ⚠️
... and 28 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #60       +/-   ##
=============================================
- Coverage     76.98%   61.00%   -15.98%     
- Complexity      618      649       +31     
=============================================
  Files           104      132       +28     
  Lines          1929     2557      +628     
  Branches        169      233       +64     
=============================================
+ Hits           1485     1560       +75     
- Misses          381      926      +545     
- Partials         63       71        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@bachletuankhai bachletuankhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java CI is failing. Please make changes accordingly and test your build with gradle task check before pushing.

*/
UserInputHistory<String> getUserInputHistory();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this earlier, but it need to be re-added too.

Copy link

@bachletuankhai bachletuankhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added features seem to work according to the demo video, but the patch coverage is too low. Will merge for now to do manual testing.

/**
* Signals that the operation is unable to find the specified event.
*/
public class EventNotFoundException extends RuntimeException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should be a RuntimeException. Can you explain more about this?

@bachletuankhai bachletuankhai merged commit 56c4ecd into AY2324S2-CS2103T-F12-4:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI to display events Add event scheduler to track all the events
2 participants