Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a panel for displaying notes #121

Merged

Conversation

drustanyjt
Copy link

Closes #95. This PR covers:

  • UI changes to display notes in a side panel.
  • find command changes the note displayed.

@drustanyjt drustanyjt changed the title Adds a panel for displaying notes. Adds a panel for displaying notes Mar 26, 2024
@drustanyjt drustanyjt force-pushed the drus-find-previews-note branch from d4fea24 to 7cc91c5 Compare March 26, 2024 09:41
@drustanyjt drustanyjt force-pushed the drus-find-previews-note branch from 7cc91c5 to 9e3ec3d Compare March 26, 2024 09:59
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 71.46%. Comparing base (42166f4) to head (ae41ab8).
Report is 17 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 4 Missing ⚠️
src/main/java/seedu/address/ui/NoteDisplay.java 0.00% 4 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 81.25% 2 Missing and 1 partial ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
- Coverage     71.63%   71.46%   -0.18%     
- Complexity      471      479       +8     
============================================
  Files            78       79       +1     
  Lines          1622     1654      +32     
  Branches        160      160              
============================================
+ Hits           1162     1182      +20     
- Misses          400      411      +11     
- Partials         60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Jayne1010 Jayne1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drustanyjt drustanyjt merged commit fdccfa0 into AY2324S2-CS2103T-F14-2:master Mar 26, 2024
5 checks passed
@drustanyjt drustanyjt added this to the v1.3 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FindCommand show note
2 participants