Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent malicious manual updating of save file #152

Merged

Conversation

drustanyjt
Copy link

This PR closes #144 .

Mainly removes occurrences of tags that caused potential issues in the save file.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.02%. Comparing base (d3482fd) to head (ae1a2b5).

Files Patch % Lines
src/main/java/seedu/address/logic/Messages.java 0.00% 1 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
- Coverage     70.68%   70.02%   -0.66%     
+ Complexity      499      492       -7     
============================================
  Files            81       81              
  Lines          1733     1715      -18     
  Branches        175      171       -4     
============================================
- Hits           1225     1201      -24     
- Misses          439      445       +6     
  Partials         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drustanyjt drustanyjt force-pushed the drus-remove-ab-files branch from 8f857af to 51067bc Compare April 4, 2024 13:42
Copy link

@tengcharmaine tengcharmaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drustanyjt drustanyjt merged commit b18f11a into AY2324S2-CS2103T-F14-2:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling manual edits to the data file
2 participants