Skip to content

Commit

Permalink
Merge pull request #177 from ashleyy2444/branch-addTestCaseFilterPL
Browse files Browse the repository at this point in the history
Add test cases for filter programming language feature
  • Loading branch information
ashleyy2444 authored Apr 14, 2024
2 parents 0f43fc1 + d3a7fb8 commit bc96c39
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@
import static seedu.address.logic.Messages.MESSAGE_PERSONS_LISTED_OVERVIEW;
import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;
import static seedu.address.logic.parser.FilterProgrammingLanguageCommandParser.createLanguages;
import static seedu.address.testutil.TypicalPersons.ALICE;
import static seedu.address.testutil.TypicalPersons.BENSON;
import static seedu.address.testutil.TypicalPersons.CARL;
import static seedu.address.testutil.TypicalPersons.DANIEL;
import static seedu.address.testutil.TypicalPersons.getTypicalAddressBook;

import java.util.Arrays;
import java.util.Collections;

import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -65,6 +70,28 @@ public void execute_zeroKeywords_noPersonFound() throws ParseException {
assertCommandSuccess(command, model, expectedMessage, expectedModel);
assertEquals(Collections.emptyList(), model.getFilteredPersonList());
}

@Test
public void execute_multipleKeywords_multiplePersonsFound() throws ParseException {
String expectedMessage = String.format(MESSAGE_PERSONS_LISTED_OVERVIEW, 4);
ProgrammingLanguageContainsKeywordsPredicate predicate = preparePredicate("Java java");
FilterProgrammingLanguageCommand command = new FilterProgrammingLanguageCommand(predicate);
expectedModel.updateFilteredPersonList(predicate);
assertCommandSuccess(command, model, expectedMessage, expectedModel);
assertEquals(Arrays.asList(ALICE, BENSON, CARL, DANIEL), model.getFilteredPersonList());
}

@Test
public void toStringMethod() throws ParseException {
ProgrammingLanguageContainsKeywordsPredicate predicate = new ProgrammingLanguageContainsKeywordsPredicate(
createLanguages("Java"));
FilterProgrammingLanguageCommand filterProgrammingLanguageCommand =
new FilterProgrammingLanguageCommand(predicate);
String expected = FilterProgrammingLanguageCommand.class.getCanonicalName()
+ "{programming_language=" + predicate + "}";
assertEquals(expected, filterProgrammingLanguageCommand.toString());
}

/**
* Parses {@code userInput} into a {@code ProgrammingLanguageContainsKeywordsPredicate}.
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package seedu.address.logic.parser;

import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;
import static seedu.address.logic.parser.CommandParserTestUtil.assertParseFailure;
import static seedu.address.logic.parser.CommandParserTestUtil.assertParseSuccess;
import static seedu.address.logic.parser.FilterProgrammingLanguageCommandParser.createLanguages;

import org.junit.jupiter.api.Test;

import seedu.address.logic.commands.FilterProgrammingLanguageCommand;
import seedu.address.logic.parser.exceptions.ParseException;
import seedu.address.model.language.ProgrammingLanguageContainsKeywordsPredicate;

public class FilterProgrammingLanguageCommandParserTest {
private FilterProgrammingLanguageCommandParser parser = new FilterProgrammingLanguageCommandParser();

@Test
public void parse_emptyArg_throwsParseException() {
assertParseFailure(parser, " ", String.format(MESSAGE_INVALID_COMMAND_FORMAT,
FilterProgrammingLanguageCommand.MESSAGE_USAGE));
}

@Test
public void parse_validArgs_returnsFilterTagCommand() throws ParseException {
// no leading and trailing whitespaces
FilterProgrammingLanguageCommand expectedFilterProgrammingLanguageCommand =
new FilterProgrammingLanguageCommand(new ProgrammingLanguageContainsKeywordsPredicate(
createLanguages("Java", "Python")));
assertParseSuccess(parser, "Java Python", expectedFilterProgrammingLanguageCommand);

// multiple whitespaces between keywords
assertParseSuccess(parser, " \n Java \n \t Python \t", expectedFilterProgrammingLanguageCommand);
}
}

0 comments on commit bc96c39

Please sign in to comment.