Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update help link and UG #173

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

dabzpengu
Copy link

@dabzpengu dabzpengu commented Apr 14, 2024

replace help link to team's UG page

add more explanation on the dateTime format and how leap days are handled

update constraints for year field

fix add resume formatting on UG

closes #143
closes #136
closes #110
closes #138
closes #107

@dabzpengu dabzpengu added bug Something isn't working documentation Improvements or additions to documentation labels Apr 14, 2024
@dabzpengu dabzpengu added this to the v1.4 milestone Apr 14, 2024
Copy link

@Lalelulilulela Lalelulilulela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* ### Format : `ddMMyyyyHHmm`
* `dd` - refers to the day and the acceptable range is from **01** to **31**
* `MM` - refers to the month and the acceptable range is from **01** to **12**
* `yy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant yyyy instead of yy

| `PROGRAMMING_LANGUAGE` | Should be alphanumeric and may contain some special characters (+ and #), and must be less than 50 characters. |
| `TAG` | Should be alphanumeric. |
| `PRIORITY` | Should be a number between 0 and 4. |
| `INTERVIEW_TIME` | Should be in the format `ddMMyyyyHHmm`.<br/>* `dd` - refers to the day and the acceptable range is from **01** to **31**<br/> * `MM` - refers to the month and the acceptable range is from **01** to **12**<br/>* `yy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999**<br/> * `HH` - refers to the hour and the acceptable range is from **00** to **23**<br/> * `mm` - refers to the minutes and the acceptable range is from **00** to **59** |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be added in the constraints of the AddCommand above as well

…into bug-fix-2

# Conflicts:
#	docs/UserGuide.md
fix UG about adding resume
@ZHANGTIANYAO1
Copy link

LGTM

@dabzpengu dabzpengu merged commit 292afcc into AY2324S2-CS2103T-T08-3:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
3 participants