Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company name feature into AddressBook #30

Conversation

Lalelulilulela
Copy link

Add Company Name feature into AddressBook.

  • Use cn/ as parameter
  • Should only be up to 100 characters

@Lalelulilulela Lalelulilulela added the enhancement New feature or request label Mar 18, 2024
@Lalelulilulela Lalelulilulela added this to the v1.2 milestone Mar 18, 2024
@Lalelulilulela Lalelulilulela self-assigned this Mar 18, 2024
@Lalelulilulela Lalelulilulela linked an issue Mar 18, 2024 that may be closed by this pull request
@dabzpengu
Copy link

resolved conflicts

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 80.70175% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 76.93%. Comparing base (108382c) to head (98a9ee7).

Files Patch % Lines
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 5 Missing ⚠️
.../java/seedu/address/storage/JsonAdaptedPerson.java 44.44% 3 Missing and 2 partials ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
+ Coverage     76.65%   76.93%   +0.28%     
- Complexity      460      474      +14     
============================================
  Files            73       74       +1     
  Lines          1465     1509      +44     
  Branches        142      149       +7     
============================================
+ Hits           1123     1161      +38     
- Misses          306      310       +4     
- Partials         36       38       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabzpengu
Copy link

LGTM :)

@Lalelulilulela Lalelulilulela merged commit 9515c0f into AY2324S2-CS2103T-T08-3:master Mar 20, 2024
5 checks passed
@Lalelulilulela Lalelulilulela deleted the branch-add-company-name branch April 4, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a Computer Science job seeker, I can add the Company name
2 participants