Branch add extra info #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modifications
In this commit we will be able to add an optional tag for infomation regarding the person.
Info tests are required as a new tag to be used in the current version of the address book.
…into branch-add-extra-info # Conflicts: # src/main/java/seedu/address/logic/commands/AddCommand.java # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/EditCommandParser.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedPerson.java # src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/logic/commands/EditPersonDescriptorTest.java # src/test/java/seedu/address/model/person/PersonTest.java # src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java # src/test/java/seedu/address/testutil/PersonBuilder.java
The previous version of the file had a missing header name for the duplicate persons which was fixed here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
============================================
+ Coverage 76.93% 77.21% +0.27%
- Complexity 474 485 +11
============================================
Files 74 75 +1
Lines 1509 1545 +36
Branches 149 152 +3
============================================
+ Hits 1161 1193 +32
- Misses 310 312 +2
- Partials 38 40 +2 ☔ View full report in Codecov by Sentry. |
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a computer science job seeker, I can add extra notes about the company
Fix issue #31