Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch add programming languages #34

Conversation

ashleyy2444
Copy link
Collaborator

Add Programming Language tag into AddressBook.

  • Use pl/ as parameter
  • Should be less than 50 characters
  • Can include special characters such as + and #

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 83.51648% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.75%. Comparing base (07916e2) to head (5cd9551).

Files Patch % Lines
.../java/seedu/address/model/util/SampleDataUtil.java 33.33% 6 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 3 Missing ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 75.00% 0 Missing and 2 partials ⚠️
...ddress/storage/JsonAdaptedProgrammingLanguage.java 80.00% 1 Missing and 1 partial ⚠️
...java/seedu/address/logic/commands/EditCommand.java 90.90% 0 Missing and 1 partial ⚠️
...c/main/java/seedu/address/model/person/Person.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     77.21%   77.75%   +0.54%     
- Complexity      485      506      +21     
============================================
  Files            75       77       +2     
  Lines          1545     1623      +78     
  Branches        152      163      +11     
============================================
+ Hits           1193     1262      +69     
- Misses          312      316       +4     
- Partials         40       45       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHANGTIANYAO1
Copy link

LGTM

@ashleyy2444 ashleyy2444 added this to the v1.2 milestone Mar 21, 2024
@dabzpengu
Copy link

LGTM

@dabzpengu dabzpengu merged commit 17647f2 into AY2324S2-CS2103T-T08-3:master Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a Computer Science job seeker, I can add programming language required for job
3 participants