Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #106

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Logging #106

merged 4 commits into from
Mar 30, 2024

Conversation

JiaXinEu
Copy link

Update logging to replace AddressBook with TeachStack.
Would appreciate some suggestions on the modification particularly in MainApp.java

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.13%. Comparing base (68a2f7d) to head (7830844).

Files Patch % Lines
src/main/java/seedu/teachstack/MainApp.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
+ Coverage     75.99%   76.13%   +0.14%     
- Complexity      489      491       +2     
============================================
  Files            78       78              
  Lines          1533     1542       +9     
  Branches        148      148              
============================================
+ Hits           1165     1174       +9     
  Misses          325      325              
  Partials         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willowisp01
Copy link

Update logging to replace AddressBook with TeachStack. Would appreciate some suggestions on the modification particularly in MainApp.java

As far as I can see for MainApp.java it's just the name that has been changed from addressbook to TeachStack. I don't see any issues.

@willowisp01 willowisp01 merged commit b174353 into AY2324S2-CS2103T-T09-1:master Mar 30, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants