Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tag to create group parameter #50

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

JiaXinEu
Copy link

No description provided.

@JiaXinEu JiaXinEu added priority.High High priority type.Task New feature labels Mar 14, 2024
@JiaXinEu JiaXinEu added this to the v1.2 milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 80.45977% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 76.31%. Comparing base (a51e106) to head (985e082).

Files Patch % Lines
.../java/seedu/address/model/util/SampleDataUtil.java 14.28% 6 Missing ⚠️
src/main/java/seedu/address/model/group/Group.java 71.42% 2 Missing and 2 partials ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 4 Missing ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 80.00% 0 Missing and 1 partial ⚠️
...c/main/java/seedu/address/model/person/Person.java 87.50% 1 Missing ⚠️
...ain/java/seedu/address/model/person/StudentId.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     76.03%   76.31%   +0.28%     
- Complexity      442      444       +2     
============================================
  Files            73       73              
  Lines          1427     1427              
  Branches        140      140              
============================================
+ Hits           1085     1089       +4     
+ Misses          308      306       -2     
+ Partials         34       32       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wongqingyee
Copy link

lgtm!

@yashma-sonara
Copy link
Collaborator

lgtm

@yashma-sonara yashma-sonara self-requested a review March 15, 2024 09:32
@JiaXinEu JiaXinEu linked an issue Mar 15, 2024 that may be closed by this pull request
@ronnnnnnnnn
Copy link

lgtm

@ronnnnnnnnn ronnnnnnnnn merged commit d2fbf28 into AY2324S2-CS2103T-T09-1:master Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High High priority type.Task New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the "tag" to become the group name/identifier
4 participants