Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] Find command don’t reject invalid r/ inputs #140

Closed
nus-se-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #191
Closed

[PE-D][Tester D] Find command don’t reject invalid r/ inputs #140

nus-se-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #191
Assignees
@gerteck
Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.Medium Bugs that cause occasional inconvenience

Comments

@nus-se-script
Copy link

Buggy input

image.png

Result

image.png

Expect the application to prohibit the invalid input in r/ instead of ignoring it.

Maybe add a constraint to check through the input?

Labels: type.FunctionalityBug severity.Medium
original: wallacexuhanxiao/ped#4
@chaaaaun
Copy link

chaaaaun commented Apr 8, 2024

Valid.

@chaaaaun chaaaaun added the severity.Medium Bugs that cause occasional inconvenience label Apr 8, 2024
@CJerrong CJerrong added the bug.Clarify Not sure, seek further clarification if we can edit. label Apr 9, 2024
@gerteck gerteck added the bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary label Apr 9, 2024
@gerteck gerteck self-assigned this Apr 9, 2024
@CJerrong CJerrong removed the bug.Clarify Not sure, seek further clarification if we can edit. label Apr 9, 2024
@gerteck
Copy link

gerteck commented Apr 9, 2024

TODO: Clarify in UG to be more specific on how the FIND command works

@gerteck gerteck mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerteck gerteck

Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.Medium Bugs that cause occasional inconvenience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Bug Reports from PE-D gerteck/tp
4 participants
@nus-se-script @CJerrong @chaaaaun @gerteck