Address Bug Reports from PE-D #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added use cases, updated glossary to match UG and added a planned enhancement
Make returned success message for logedit more general.
Update appropriately to address bug reports raised in PE-D by adding planned enhancements and clarifications.
Add multi-way pairing
CJerrong
reviewed
Apr 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
============================================
+ Coverage 76.95% 76.97% +0.01%
Complexity 760 760
============================================
Files 98 98
Lines 2660 2662 +2
Branches 304 304
============================================
+ Hits 2047 2049 +2
Misses 494 494
Partials 119 119 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181 , explicitly added mention that extra params in help will be ignored.
Closes #176 , added planned enhancement to allow flexible logedit
Closes #174 , Closes #142 find UG updated in previous PR (ty chuanen)
Closes #172 , added planned enhancement in DG
Closes #169 , added a general overarching disclaimer under Features in UG that index 0 throws invalid command format (ideally, closes #146 duplicate issue as well)
Closes #159 , add planned enhance
Closes #153 , widen scope of message and not give time for
logeditCloses #140 , add note that invalid filters ignored
Also adds some instructions for manual testing.