Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester D] Find command do react to invalid input and list 0 person #142

Closed
nus-se-script opened this issue Apr 5, 2024 · 1 comment · Fixed by #191
Closed

[PE-D][Tester D] Find command do react to invalid input and list 0 person #142

nus-se-script opened this issue Apr 5, 2024 · 1 comment · Fixed by #191
Assignees
Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.Low Bugs that are unlikely to affect normal operations

Comments

@nus-se-script
Copy link

Buggy input

image.png

Buggy output

image.png

Expect to see an error message shows : we don't support this type of search.

Can add an exception to handle such issue.


Labels: type.FeatureFlaw severity.Medium
original: wallacexuhanxiao/ped#5

@chaaaaun
Copy link

chaaaaun commented Apr 8, 2024

From a user perspective, this would indeed seem like a bug. In the backend, the Parser in the backend likely interprets this as a generic KEYWORD and not a flag. Possibly solution could be to rework the Parser to detect [letter]/ as a flag, but not sure how much work that is.

Also have to consider that people could legitimately have p/123028 be their name nowadays, in which case that would be a valid search.

@chaaaaun chaaaaun added the severity.Low Bugs that are unlikely to affect normal operations label Apr 8, 2024
@CJerrong CJerrong added the bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary label Apr 9, 2024
@gerteck gerteck self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.Low Bugs that are unlikely to affect normal operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants